test: add unit tests for stas module utility functions#478
Merged
martin-belanger merged 1 commit intolinux-nvme:mainfrom Apr 6, 2026
Merged
test: add unit tests for stas module utility functions#478martin-belanger merged 1 commit intolinux-nvme:mainfrom
martin-belanger merged 1 commit intolinux-nvme:mainfrom
Conversation
Add test-stas.py covering four untested functions in staslib/stas.py: _excluded(), tid_from_dlpe(), remove_excluded(), and remove_invalid_addresses(). These are pure or near-pure functions that do not require GLib or D-Bus, making them straightforward to test. Also register the new test in test/meson.build. Signed-off-by: Martin Belanger <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #478 +/- ##
==========================================
+ Coverage 58.72% 59.34% +0.61%
==========================================
Files 16 16
Lines 2612 2612
==========================================
+ Hits 1534 1550 +16
+ Misses 1078 1062 -16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add test-stas.py covering four untested functions in staslib/stas.py: _excluded(), tid_from_dlpe(), remove_excluded(), and remove_invalid_addresses(). These are pure or near-pure functions that do not require GLib or D-Bus, making them straightforward to test. Also register the new test in test/meson.build.